search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
38 stars 16 forks source link

revise recr_dist output to show both sexes #612

Closed Rick-Methot-NOAA closed 2 months ago

Rick-Methot-NOAA commented 3 months ago

Concisely describe what has been changed/addressed in the pull request.

revise recruitment distribution output to show males and females. This is helpful for hermaphroditism applications

What tests have been done?

see test file linked in the issue. revised output is visible in the issue and shows the desired feature

Is there an input change for users to Stock Synthesis?

[x] No, there was no input change.

iantaylor-NOAA commented 3 months ago

The test-r4ss-with-ss3 github action is failing here in modifications I made to the SSplotRecrdist() plot to take advantage of the output for males and females. However, I can't replicate the issue. The two models that are causing problems, Simple_with_DM_sizefreq and two_morph_seas_areas, work fine when running with the SS3 exe from this 611... branch and the main branch of r4ss on my local computer. Trying to trap for incorrectly specified values in the r4ss function didn't work either and it's hard to debug without replicating the problem.

I tried running a github codespace to debug further but am having trouble getting that running. I will be in Sea Safety Training for the next few days but can try again on Monday. Hopefully the delay isn't a big deal as I don't think the changes in this PR interact with other work.

@e-perl-NOAA if you feel like trying to debug via codespaces or any other method before I get back to it, feel free.

e-perl-NOAA commented 3 months ago

The r4ss issue is resolved so this should be good to go now.

github-actions[bot] commented 2 months ago

Here are the successful executable builds from your PR: ss3-ubuntu-latest ss3-macos-12 ss3-windows-latest ss3-macos-latest