search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
38 stars 16 forks source link

revise calc of spawn_time_season #620

Closed Rick-Methot-NOAA closed 2 months ago

Rick-Methot-NOAA commented 2 months ago

Concisely describe what has been changed/addressed in the pull request.

What tests have been done?

season duration calculation have been compared to season duration for a survey with same timing. They did not match before, now they do.

Where are the relevant files?

Test file is in email with nmfs.stock.synthesis

What tests/review still need to be done?

None

Is there an input change for users to Stock Synthesis?

[x] No, there was no input change.

Additional information (optional).

Rick-Methot-NOAA commented 2 months ago

The nice work was by Leire Citores (AZTI) who did the investigation showing that the timing calculation was wrong.

Rick-Methot-NOAA commented 2 months ago

note that nothing in our test suite was affected by this error. It is just the unusual cases with multi-seasons and spawn_month not at beginning of a season.