search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
38 stars 16 forks source link

[Bug]: Unable to include multiple CAAL records for same fleet, year, and bin with different ageing errors #622

Closed chantelwetzel-noaa closed 1 month ago

chantelwetzel-noaa commented 1 month ago

Describe the bug

I was running some exploratory runs to include ages from a new ageing method and ran into a strange error. The model was including two sets of CAAL data from the same fleet and years using two separate ageing errors. The message in the terminal was fairly cryptic:

Warning 1 Fatal Error! fatal: max agecomp obs per fleet*time is 100; you requested 101 for fleet x year 7 2017

When I removed one set of the CAAL data, the model ran. I then tried running the model with the two separate CAAL datasets but had them use the same ageing error and I got the same fatal error message. Given that, I think the issue arises when a user in inputting more than one line of CAAL data for the same year, fleet, and length bin.

To Reproduce

I will email the model files directly where there are two sets of CAAL data from 2017-2022, one labeled traditional-ages and one called ft-nirs.

Expected behavior

If this is a relatively easy fix, allowing users to include CAAL from multiple age reading methods would be useful. Next year's West Coast sablefish assessment may have this need, and allowing the use of all data will allow us to include all data as CAAL.

Screenshots

No response

Which OS are you seeing the problem on?

Windows

Which version of SS3 are you seeing the problem on?

3.30.21

Additional Context

No response

Rick-Methot-NOAA commented 1 month ago

got it. This affects indexing of observations, so may be a big deal to fix. I'll take a look.