search

nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
38 stars 16 forks source link

Anyone still using Mac OS 12? Deprecate the build that's failing? #629

Closed iantaylor-NOAA closed 1 month ago

iantaylor-NOAA commented 1 month ago

The build-ss3 github action is failing because of errors in the macos-12 build. The macos-14 build is working as are windows-latest and ubuntu-latest: https://github.com/nmfs-ost/ss3-source-code/actions/workflows/build-ss3.yml.

Among the warning messages is the following:

Warning: You are using macOS 12. We (and Apple) do not provide support for this old version. It is expected behaviour that some formulae will fail to build in this old version. It is expected behaviour that Homebrew will be buggy and slow. Do not create any issues about this on Homebrew's GitHub repositories. Do not create any issues even if you think this message is unrelated. Any opened issues will be immediately closed without response. Do not ask for help from Homebrew or its maintainers on social media. You may ask for help in Homebrew's discussions but are unlikely to receive a response. Try to figure out the problem yourself and submit a fix as a pull request. We will review it but may or may not accept it.

That makes me think we should remove the macos-12 build from the workflow and trust that mac users have all upgraded to newer versions. If anyone is aware of folks still using OS 12, please comment here.

iantaylor-NOAA commented 1 month ago

@e-perl-NOAA just noted that this has been resolved in #621 but the "191-spawner-recruitment-with-a-b-formulation" branch associated with PR #442 is behind main and doesn't include that update. Rebasing that branch onto main could resolve the problem, as would just merging it into main.