nmfs-ost / ss3-source-code

The source code for Stock Synthesis (SS3).
https://nmfs-ost.github.io/ss3-website/
Creative Commons Zero v1.0 Universal
38 stars 16 forks source link

Build macos-latest admb from source #641

Closed e-perl-NOAA closed 1 week ago

e-perl-NOAA commented 2 weeks ago

Concisely describe what has been changed/addressed in the pull request.

Per the usual, mac is always the problem child. While the macos-latest exe was building using the admb docker image, it wasn't actually working which wasn't detectable until r4ss r_cmd_check() tests ran on macos-latest. Using the build from source workflow, I created a ss3_osx_arm64 exe that works, so I have modified our ss3-build workflow to build both versions of mac from source.

In the future, I think running the test models with macos latest in addition to it running on linux would be useful, especially since no one has a M2 chip and beyond mac to test on anymore (my mac is old). It would increase the run time but it would ensure that we aren't finding out that it doesn't work later than we want. I'm happy to work on this if you agree. I can even add it as a part of this PR. It won't take long to implement.

What tests have been done?

Where are the relevant files?

What tests/review still need to be done?

None.

Is there an input change for users to Stock Synthesis?

Additional information (optional).