nmfs-ost / ss3-test-models

Stock Synthesis models used for testing
Creative Commons Zero v1.0 Universal
3 stars 1 forks source link

add missing growth patterns #25

Open k-doering-NOAA opened 2 years ago

k-doering-NOAA commented 2 years ago

2, 3, 4, 5 are not represented.

Rick-Methot-NOAA commented 2 years ago

I think it makes sense to have collection of variants off of simple for each NatMort type and each growth type. Is that what you meant by growth pattern: 0 #_natM_type:_0=1Parm; 1=N_breakpoints; _2=Lorenzen; _3=agespecific; _4=agespec_withseasinterpolate; _5=BETA:_Maunder_link_to_maturity

_no additional input for selected M option; read 1P per morph

# 1 # GrowthModel: 1=vonBert with L1&L2; 2=Richards with L1&L2; 3=age_specific_K_incr; 4=age_specific_K_decr; 5=age_specific_K_each; 6=NA; 7=NA; 8=growth cessation

k-doering-NOAA commented 2 years ago

Yes, Exactly! I was looking through the current test set and seeing what was not represented.

Another option besides making the version of simple is seeing if we can change an existing model that is already being run and runs quickly. That way, we make the model set more orthogonal, rather than having simple with all the same features but just 1 difference in MG options.

Rick-Methot-NOAA commented 2 years ago

With the approach I suggested, it would be more like a unit test of growth (or of all biology) that is run on request if the code change is anything in ss_biofxn.tpl. A similar type of test could run all selectivity options if there is any change in ss_selex.tpl.

k-doering-NOAA commented 2 years ago

Hmm, that does make some sense. We could of course do both approaches, as I'm not sure which one will pan out to be easier. The unit test one sounds like it would take more time to me, but maybe I am overthinking it.

Rick-Methot-NOAA commented 2 years ago

Any "simple" run is rather quick. So, I was thinking that the unit test runs I sketched would be an additional gha that is only invoked if certain files are changed.

k-doering-NOAA commented 2 years ago

Thanks, Rick, I think we are on the same page!

By "take more time", I meant time to develop - I agree the simple runs will run quick once they are set up!