Update model files to new ss exe

[github-actions[bot]]

Automated changes by create-pull-request GitHub action

[iantaylor-NOAA]

@e-gugliotti-NOAA, thanks for all your work on the SS3 release and it's great to see a workflow to update the test models in action.

I was curious what had changed in the files so I took a quick look at these changes. A few further tweaks seem necessary.

• In the case of models/tagging_mirrored_sel/data_boot_new.ss, I think that the use of "boot" in the input data file name caused it to get deleted by this line: https://github.com/nmfs-stock-synthesis/test-models/actions/runs/4147962433/workflow#L74 (which is useful for excluding bootstrapped data files in general, but is incorrect in this case because of our poor choice of input file name). The easy solution that I would suggest is renaming the file to data.ss and changing the starter file entry to match.
• I'm not sure if adding the ss exe was intentional or not.
• Lastly, it seems like the workflow is missing a step to replace the original input files with the ss_new files. I think you could use r4ss::populate_multiple_folders(..., use_ss_new = TRUE, overwrite = TRUE) after the models run to accomplish this.

[e-perl-NOAA]

Yes, I was trying to work on what was going wrong with that workflow on Friday as something seemed to be not fully right but it was right at the end of my day. I am working on this today.

Elizabeth F. Gugliotti (she/her)

Scientific Software Specialist for Stock Synthesis

ECS Federal contracted to

NOAA/NMFS/National Stock Assessment Program

Mobile: 843-469-1074

On Fri, Feb 10, 2023 at 5:28 PM Ian Taylor @.***> wrote:

@e-gugliotti-NOAA https://github.com/e-gugliotti-NOAA, thanks for all your work on the SS3 release and it's great to see a workflow to update the test models in action.

I was curious what had changed in the files so I took a quick look at these changes. A few further tweaks seem necessary.

• In the case of models/tagging_mirrored_sel/data_boot_new.ss, I think that the use of "boot" in the input data file name caused it to get deleted by this line: https://github.com/nmfs-stock-synthesis/test-models/actions/runs/4147962433/workflow#L74 (which is useful for excluding bootstrapped data files in general, but is incorrect in this case because of our poor choice of input file name). The easy solution that I would suggest is renaming the file to data.ss and changing the starter file entry to match.
• I'm not sure if adding the ss exe was intentional or not.
• Lastly, it seems like the workflow is missing a step to replace the original input files with the ss_new files. I think you could use r4ss::populate_multiple_folders(..., use_ss_new = TRUE, overwrite = TRUE) after the models run to accomplish this.

— Reply to this email directly, view it on GitHub https://github.com/nmfs-stock-synthesis/test-models/pull/38#issuecomment-1426422227, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4GU6UNXD3KEELYP5NZELD3WW26J7ANCNFSM6AAAAAAUYI3PLQ . You are receiving this because you were mentioned.Message ID: @.***>