search

nmfs-ost / ss3-workflows

This repo contains a collection of reusable workflows found helpful for the SS3 project
Creative Commons Zero v1.0 Universal
0 stars 0 forks source link

reduce number of ss3 compile runs in github actions #32

Closed Rick-Methot-NOAA closed 2 years ago

Rick-Methot-NOAA commented 2 years ago

The github test runs for every push to the stock_synthesis code repo has grown to >10 and takes nearly an hour. Would it be possible to reduce this to 3 (compile for windows, compile for unix, run using existing parameters). Then invoke the remaining actions in a manually triggered request?

k-doering-NOAA commented 2 years ago

Thanks @Rick-Methot-NOAA, I missed this issue until just now!

I looked and the slowest github action runs in 35 minutes. I think one way to reduce the number of runs is to not launch new runs on pull requests when the job is already running on every push - this is redundant. I made this change in a branch for now, so we can revisit after the ss3 release: https://github.com/nmfs-stock-synthesis/stock-synthesis/tree/gha_triggers.

I'm happy to go over the test runs in more detail and what each of them do to see if we want to change the triggers futher.

I am hesitant to have some workflows that are only triggered manually, because I think we won't run them as much as we should. For some, however, we could change to running less frequently.

k-doering-NOAA commented 2 years ago

Feel free to reopen if more changes are desired, Rick!