Closed meffmadd closed 1 year ago
Hi, I couldn't work on it this weekend but will start now and fix the configs so that the tests work again. I will also add a test case that tests the behavior.
Base: 70.01% // Head: 70.04% // Increases project coverage by +0.02%
:tada:
Coverage data is based on head (
28d0e95
) compared to base (8dee583
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Great work! Thank you so much for making these changes!
Hi @meffmadd, thank you so much for this contribution. It looks great! 😁🎉
Before we merge, please may you update the checkpointing in the configs as some tests are currently failing and for documentation purposes?
false
to maintain current behavior)true
so we know the checkpoint behavior works).On that note, we might want to just add the checkpointing to the pytorch lightning train step, using the same hook. Then possibly at the end, load the checkpoint after everything to make sure it works.