nmoehrle / mvs-texturing

Algorithm to texture 3D reconstructions from multi-view stereo images
Other
931 stars 328 forks source link

packaging `tex` as a standalone library #161

Open bitonic opened 3 years ago

bitonic commented 3 years ago

Currently the cmake files install a static libtex.a, and no header files. It is easy to make them install a .so files and the header files for tex, but they refer to mve headers using quotes includes, so some additional reworking would be necessary.

Would you be in favor of such a rework if I were to do it? I think it would be extremely valuable to be able to reach for the algorithms present in tex directly, even if the API is not stable.

DaniilSNikulin commented 3 years ago

The functionality you are requesting was implemented in this branch. On linux it works well. Should be fine on other systems too, but I haven't tested. Feel free for any comments and modifications.

bitonic commented 3 years ago

@DaniilSNikulin that is excellent, thank you! I'll try it out. It would be great to "mainline" this.

nmoehrle commented 3 years ago

Would be happy to merge it to mainline if there are no caveats :-)

bitonic commented 3 years ago

@DaniilSNikulin are there any caveats that @nmoehrle might be worried about? If not, could you submit a PR? I think this would be a big boon to people wishing to integrate this great piece of software in custom computer vision pipelines.