nmoehrle / mvs-texturing

Algorithm to texture 3D reconstructions from multi-view stereo images
Other
974 stars 334 forks source link

Resolve #89 #91

Closed nmoehrle closed 6 years ago

dakotabenjamin commented 6 years ago

It needs c_str() casts and texturing.h needs updating with the added tmp parameter. And the rmdir function is undefined.

dakotabenjamin commented 6 years ago

I think there's some issues with the mve version. I will finish testing in the morning (EST)

nmoehrle commented 6 years ago

I am updating mve right now, thanks for reporting the other issues.

dakotabenjamin commented 6 years ago

It's not deleting the dataset. Don't you have to rmdir(tmp_dir.c_str()) not out_dir?

dakotabenjamin commented 6 years ago
    /* Remove temporary files. */
    std::cout << "\tDeleting temporary data... " << std::endl;
    for (util::fs::File const & file : util::fs::Directory(tmp_dir))
    {
        std::cout << file.path + "/" + file.name << std::endl;
        util::fs::unlink((file.path + "/" + file.name).c_str());
    }
    util::fs::rmdir(tmp_dir.c_str());
    std::cout << "\tDone!" << std::endl;

You can delete the stdout if you want, this works for me

nmoehrle commented 6 years ago

You are absolutely right I'll change and merge it tomorrow :-) Thanks!

nmoehrle commented 6 years ago

Given my current record on the issue I would like get another OK from you before merging ;-)

dakotabenjamin commented 6 years ago

It works great now 😀

nmoehrle commented 6 years ago

Really appreciated your help - thank you!