search

nmondal / cowj

[C]onfiguration [O]nly [Web] on [J]VM
Apache License 2.0
16 stars 11 forks source link

[code review] Azure Plugins #126

Closed ajafri2001 closed 1 month ago

ajafri2001 commented 1 month ago

https://github.com/nmondal/cowj/issues/107

Added azure secretmanager in SecretManager.java

nmondal commented 1 month ago

Ok good stuff bunch of stuff need to taken care of.

  1. The branch should be called azure
  2. The branch should have all changes that is required for Azure integration - then merged
  3. This specific changes probably did not implement the env() correctly:

https://stackoverflow.com/questions/53499397/how-to-get-all-secrets-in-one-call-azure-key-vault