search

nmoya / whatsapp-parser

Parser to the What's App log file.
MIT License
47 stars 23 forks source link

pip support #12

Closed manu-chroma closed 7 years ago

manu-chroma commented 7 years ago

Hey, I've finally found time to finish the work on making a pip installable package for this project.

I was hoping for you to test the pip package locally and get it merged soon. There is some meta-data such as author name, email id which is required in setup.py Then you can edit some of the meta info in setup.py so we can publish this package on pypi easily.

nmoya commented 7 years ago

@manu-chroma Yes, I plan to do this today. I will let you know my progress.

manu-chroma commented 7 years ago

Good to hear from you! let me create a PR, it'll contain all the files and new directory structure for the project. you can make changes in the PR itself or after merging :)

nmoya commented 7 years ago

@manu-chroma opened this one: https://github.com/nmoya/whatsapp-parser/pull/16

nmoya commented 7 years ago

It's uploaded! https://pypi.python.org/pypi/whatsapp-parser/1.0.0

I will update the readme file with the new instructions

manu-chroma commented 7 years ago

oops. I think one other bug slipped my notice. I'll test and patch it in a few hours. the error is with naming convention of the console entry script. ps: pip install works perfectly. image

nmoya commented 7 years ago

Glad that pip install worked! Blame the reviewer!!

nmoya commented 7 years ago

@manu-chroma I added you as a collaborator to the project. Let's keep opening PRs and keep with the reviews, just so we can always stay up to date with the changes.

nmoya commented 7 years ago

@manu-chroma I added master as a protected branch, so we can't force push to it. PR's going to master will be blocked until review. Since you are also an administrator, you can merge without the review, but it's a good practice to wait for a while.

manu-chroma commented 7 years ago

@manu-chroma I added you as a collaborator to the project.

I'm glad to help and contribute.

Let's keep opening PRs and keep with the reviews, just so we can always stay up to date with the changes. @manu-chroma I added master as a protected branch, so we can't force push to it. PR's going to master will be blocked until review. Since you are also an administrator, you can merge without the review, but it's a good practice to wait for a while.

Sounds alright to me. Opening PR's would ensure that there's code review and only useful code is merged into the master.

manu-chroma commented 7 years ago

btw what name would you suggest for the executable i.e. <executable name> -h

I'm confused between wp_parser and wp_chat

nmoya commented 7 years ago

I would go with wp_parser so it's consistent with the name of the package that the user installed

On Feb 2, 2017 21:46, "Manvendra Singh" notifications@github.com wrote:

btw what name would you suggest for the executable i.e. -h

I'm confused between wp_parser and wp_chat

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nmoya/whatsapp-parser/issues/12#issuecomment-277078202, or mute the thread https://github.com/notifications/unsubscribe-auth/ABr44Erdf20Rl03BTvjX0l-EE_v7rRfiks5rYkCYgaJpZM4L0Rt1 .

manu-chroma commented 7 years ago

I would go with wp_parser so it's consistent with the name of the package that the user installed

sure, I feel the same.

seems like this one is done now. closing.