Closed gtadiparthi closed 8 years ago
Could you add the contents of commit f98fc8b
in a separate folder (e.g. applications/speech
, or demos/speech
), and a readme inside that folder that links to your blog post, just for reference? Since it adds a lot of dependencies to the code, I don't want to become confusing the source code of the repository with an application.
Could you please remove commit 7a1ec2c
of the Pull Request?
Hi
I made the changes that you requested: removing print i and changing the indentation. You can ignore additional applications and the other pull request.
@gtadiparthi I'm really sorry for being pecky, but your new commit added some files: deactivate/include/python2.7
, test/22_OW_MT.txt.json
, test/34_AR_BQ.txt.json
, transcript.py
, parse_whatsapp.py
, which shouldn't be merged.
I can do the merge manually, but then the commit would be in my name, not yours. Ando you may be interested in open source contributions.
If you are, I recommend you do the following:
Create a branch in your local repository based in nmoya:master.
Manually copy the content of datelib.py
and main.py
to this branch. Do a commit in this branch. Close this Pull Request and open another one, requesting a merge between your new branch and my master.
If you are not interested in open source contributions, let me know that I do this process manually, (but it will look like I did the change, not you, since I will be doing the commit).
Another thing, yesterday I removed the main.py
file, since it was deprecated. So you should merge your contribution to chat.py
file. (Which is the new main.py).
Hello:
Thank you for the nice email.
I will make the changes at the end of day today (20 hours later).
Thanks.
On Mon, Nov 23, 2015 at 7:13 AM, Nikolas Moya notifications@github.com wrote:
@gtadiparthi https://github.com/gtadiparthi I'm really sorry for being pecky, but your new commit added some files: deactivate/include/python2.7, test/22_OW_MT.txt.json, test/34_AR_BQ.txt.json, transcript.py, parse_whatsapp.py, which shouldn't be merged.
I can do the merge manually, but then the commit would be in my name, not yours. Ando you may be interested in open source contributions. If you are, I recommend you do the following: Create a branch in your local repository based in nmoya:master. Manually copy the content of datelib.py and main.py to this branch. Do a commit in this branch. Close this Pull Request and open another one, requesting a merge between your new branch and my master.
If you are not interested in open source contributions, let me know that I do this process manually, (but it will look like I did the change, not you, since I will be doing the commit).
Another thing, yesterday I removed the main.py file, since it was deprecated. So you should merge your contribution to chat.py file. (Which is the new main.py).
— Reply to this email directly or view it on GitHub https://github.com/nmoya/whatsapp-parser/pull/5#issuecomment-158964378.
I will do as you say. Closing this pull request and will add another.
Hi
I made the following changes.
Thanks.