Closed NRayya closed 4 weeks ago
The problem is that we should not change the hierarchy of CHEBI in our ontology, as this is bad practice. This means we have to live with this until it gets resolved in CHEBI. I don't know if there is an issue for this at CHEBI currently.
Two threads that shed some more light on why atom is not subsumed under molecular entity: https://github.com/ebi-chebi/ChEBI/issues/688 https://github.com/EnvironmentOntology/envo/issues/977
From the ENVO issues thread I take home that in our context using the atom branch seems to be more correct, as we are di
I wrote this to @StroemPhi before, but it shocking to me that we live in an ontological world before 1912. Until that point chemistry looked on atoms, ions and molecules. Consequently, Wilhelm Ostwald (Nobel price 1909) coined the unit Mol in 1983, which is one of the seven SI base units. Mineralogy was closely bound to geology at that time, but Max von Laure discovered diffraction of x-rays by crystals and received the Nobel price in 1914. The Nobel price a year later was given to Bragg and Bragg for the first crystal structure (diamond) and that what we now call Braggs-Law. Notably, Laurence Bragg was only 25 year old when he received this price and is still the youngest scientist who ever received that price.
Since that days it came apparent that there are more complex things out there in chemistry, which are very different than the molecules scientists looked in these days. I agree that this was of modest interest to many organic chemists, but more than 100 years later, this has changed and chemists are aware of this (although, to my great regret, I know of exceptions). What is chemistry about? The properties, behaviour and transformation (reaction) of matter.
Something, for that some people would say its simply wrong or other might say this this is highly misleading, won't get better if it is repeated and repeated and over and over again.
The problem is that we should not change the hierarchy of CHEBI in our ontology, as this is bad practice. This means we have to live with this until it gets resolved in CHEBI. I don't know if there is an issue for this at CHEBI currently.
Totally agree, I had to open the issue as we had the discussion. But the way I see it is that CHEBI implementation is correct as they have only a subset of atoms under molecular entity which are constitutionally or isotopically distinct atom. My understanding is they are covering the cases where "an atom serves as a molecule" such as with noble gases
In all cases, including only solvents and references in nmrCv might lead us not to use the atoms at all and it gets removed from nmrCV.
I just saw that a previous comment of mine was incomplete. What I wanted to write there is that, only in the case of us needing to say that e.g. 1H NMR is probing/stimulating the nuclei of H atoms in the sample, I would opt for using the atom branch. In other use cases (solvents & chemical shift reference compounds) the molecular entity branch is better.
Reason: CHEBI:atom has the subclass of axiom "has part some atomic nucleus". When/if we come to define the various types of NMR spectroscopy assays using the probed nucleus as a differentiation axis, we'd probably want to do so axiomatically along the lines of: 1H NMR spectroscopy = NMR spectroscopy and ("probes" some (atomic nucleus and "part of" some hydrogen atom))
.
One question I would like to add: Who serves whom?
As no actions were decided for this issue, it will be closed in favor of the corresponding discussion
In CHEBI, atom appears under chemical entity. However molecular entity definition includes "Any constitutionally or isotopically distinct atom...". We need to decide were atom should go