nmradcc / documents

This is a working repository for development of NMRA DCC Standards, Recommended Practices, Technical Notes, and other documents.
Other
2 stars 1 forks source link

S-9.1.1.3 Sep 9, 2020 Version Review Comments #29

Open bakerstu opened 3 years ago

bakerstu commented 3 years ago

This is a review of both S-9.1.1.3 and TN-9.1.1.3.

There are some template style issues with the document. I don't want to dwell to much on those. We can get together offline and work through correcting these. I'm happy to offer my help.

S-9.1.1.3

Document Header/Footer: replace X-9.99.99 Draft with S-9.1.3 Draft Document Footer: Update copyright year, missing "21 MTC Decoder Interface" text. Line 11: This S-9.2.3 reference was likely copied in from the S-9.1.1.5 reference document. In S-9.1.1.5, its relevance is that when used as a function only decoder (no motor output), the decoder must still provide a means to activate the current based service mode acknowledgement. I don't see any such reference to the same use case in this standard, therefore, this document reference should be omitted. Line 13: TN-9.1.1 does not exist. We had planned it at one time and then punted at the last minute. Remove reference. Line 16: This is a continuation of the previous line and should not have its own bullet. Line 18: This is a continuation of the previous line and should not have its own bullet. Line 25: The latest RCN-121 currently being voted on supports up to 12 function outputs total with the 2 sensor inputs being defined differently. We should update our proposal to support the latest RCN-121 being voted on now. Line 42: The defined term is "System Board" not "system main PCB (printed circuit board)". Change one or the other of these to be consistent. Line 44: The defined term is "System Board" not "system PCB". Change one or the other of these to be consistent. Line 44: There is no Table 1. This does not appear to be a proper document reference. Figure 8: (top of page 3) where are figures 1 through 7 that proceed this? Can we use the updated graphics from RCN-121. RailCommunity has offered to provide the sources of all their graphics. I think we should make use of this offer and save ourselves some effort. Table 5: (pages 3 and 4) where are tables 1 through 4 that proceed this? I don't particularly like the way we have presented the text on page 2 combined with this table. I think it is very difficult to follow and easy to make a mistake trying to implement it. I suggest we copy exactly what is on page 3 of RCN-121 while adopting similar wording to what is on page 2. If a table flows onto another page, the table header should be repeated on the next page. There is a table property setting for this in Microsoft Word. Line 101: remove "and input", only outputs draw current. Lines 101 - 103: I'm having a difficult time following the intent of these statements. Where do they come from? are they in RCN-121? Table 6: (top of page 6) Update to the latest RCN-121 currently being voted on. Pins 16 (V+) and 20 (GND) are not part of group 2 They do not belong in any group. Lines 117 - 119: (Group 4) this text should be updated to match the RCN-121 currently being voted on. Lines 121 - Lines 123: (Group 5) The "cab reverse lights" option is described here in a confusing fashion. The definition is also missing that these are open collector outputs switched against ground. Lines 126 - 127: (Group 7) This text should include a statement about the levels being TTL/LVTTL. Figure 11: (top of page 8) Where are figures 9 through 10 that proceed this? The figure is missing two important dummy plug options that are present in RCN-121.

TN-9.1.1.3

Document Footer: Update copyright year Line 30: Can we be more specific about the reference to 3.5mm? Is this a minimum, maximum? Should we define a range? Line 43: remove "recommends" at the end of this line. This is referring to a requirement. It is not optional. Lines 43 - 35: I Recommend a wording change to "While AUX3 through AUX6 are always required to support TTL/LVTTL logic-level outputs, an open collector/drain option switched against ground may be provided. The default configuration must support TTL/LVTTL logic level on AUX3 through AUX6." General: Please review RCN-121 Appendix C and ensure that all this information gets incorporated into the technical note somewhere.