nmrf / sadata

Samoa's Human Rights National Mechanism for Reporting and Follow-up (NMRF) - Client-side application
Other
0 stars 0 forks source link

Batch editing #2

Closed ashbowe closed 7 years ago

ashbowe commented 7 years ago

Hi Timo,

I've just been adding some of the other Samoa recommendations in and went to do some batch editing at the end. E.g. I selected all of the recs which didn't have a human rights body assigned to it, selected all and then assigned the UPR to them. Nothing really happens and then after a while the screen goes blank. If you refresh the page it has worked but I was just wondering if this is supposed to happen?

Ta, Ash

ashbowe commented 7 years ago

Update: the page did eventually come back to life but after at least 5 mins!

tmfrnz commented 7 years ago

Thanks @ashbowe: Batch updating can take some time and we will still have to improve messages etc for user feedback. Still, of course 5 minutes is too long! How many entities did you update?

ashbowe commented 7 years ago

91

tmfrnz commented 7 years ago

Let me quickly un-assign and re-assign those to reproduce.

ashbowe commented 7 years ago

Okeydokey

tmfrnz commented 7 years ago

Also, we are potentially running into those performance issues I mentioned in my email

tmfrnz commented 7 years ago

Batch category update for 91 recommendations took 17s. In addition there was a lag of several seconds to update the list. But overall not close to 5 min mentioned. screenshot 2017-06-22 13 43 02

Will investigate if and how this can be improved regardless.

tmfrnz commented 7 years ago

See https://github.com/dumparkltd/hr-nmrf-client/issues/246, https://github.com/dumparkltd/hr-nmrf-client/issues/248

tmfrnz commented 7 years ago