search

nmrih / source-game

Bugs and issues reporting for NMRiH1
http://store.steampowered.com/app/224260
57 stars 25 forks source link

[public] Players avoid "ghost" connecting clients #1006

Closed dysphie closed 2 years ago

dysphie commented 6 years ago

Players who are connected but have yet to click "Join game" will show up as predicted_viewmodels. These viewmodels obstruct player movement since other clients will try to avoid them as if they were alive players.

  1. Client A: create a game (nmo_suzhou is a good example for this)
  2. Client B: connect to the game, but don't click "Join game"
  3. Client B: press escape to preview your location, or just getpos

20180607083237_1

  1. Client A: go to those coordinates with picker enabled
  2. Client A: try walking through this, you should get pushed around:

20180607083306_1

I think these also the reason why you sometimes see a pair of arms floating around while in spectator mode, but I have no confirmation for that yet.

dysphie commented 6 years ago

Seems fixed as of src-r4495/dev-r8829

Mateos81 commented 6 years ago

Just a question: have you tested the case when a player already playing is standing on that position and the player has connected and is spawning at that moment? To be sure they don't get each other stuck (or die?)

dysphie commented 6 years ago

Reopening because this still happens (but seemingly only during practice mode, which is better). I can also only reproduce it on certain maps. No viewmodel spawns but players still avoid the coords where the camera is located at.

Only tested with SourceTV, no real players, I can't walk through this:

20180703095912_1

(this is nmo_miner_detour_v3, in case you're wondering)

Bubka3 commented 6 years ago

I can also only reproduce it on certain maps.

Can you reproduce it on an official map?

Holycrapjimhox commented 5 years ago

I can confirm that this still occurs on the public release of 1.1.0.0

dysphie commented 5 years ago

This happens whenever the game calls for RespawnPlayers and someone is still connecting (hasn't yet clicked "Join Game"). Clients will attempt to avoid them already. I wrongly thought removing the predicted viewmodels would fix this. nmo_miner_detour_v3 is simply the easiest to test because it calls this function a lot in this particular segment. Should also affect official maps with the right timing

felis-catus commented 2 years ago

Fixed by new player avoidance method introduced in 1.12.3.