search

nmrih / source-game

Bugs and issues reporting for NMRiH1
http://store.steampowered.com/app/224260
57 stars 25 forks source link

TSAROUHAS voice set missing closedcaption #861

Closed AtheistNMRiH closed 2 years ago

AtheistNMRiH commented 6 years ago

my apologize, I guess I used wrong termin anyway, looks like problem is on public build too m60deployed_gun0000

now I'm not sure if it is supposed to be closecaptions for "plenty of magazines" on all voice sets, if no, then that is not a bug

TSAROUHAS hasn't any of closecaption 1) choosing command Follow me -> no closecaption m60deployed_gun0002 m60deployed_gun0003 2) reloading -> no closecaprtion m60deployed_gun0004 and etc

what I expected to see: m60deployed_gun0000

Bubka3 commented 6 years ago

I cant reproduce this. Can you better explain what is missing and what you expect to see, with screenshots?

AtheistNMRiH commented 6 years ago

sure, i'll do it in few hours

AtheistNMRiH commented 6 years ago

check first comment

Bubka3 commented 6 years ago

This is a translation issue. I will take care of it.

Bubka3 commented 6 years ago

TSAROUHAS voice set missing closedcaption

Winning117 commented 6 years ago

Taunt is missing closed captions for English so not entirely a translation issue. Tested in src-r4405/dev-r8773.

Bubka3 commented 6 years ago

Taunt doesn't have closed captions because it doesn't exist in the translation file. It doesn't exist in the translation file likely because our closed captions are not true. We show a generic message of what the line should say instead of what the audio actually says for any given lines. This might work for stuff like [Follow me!], but the taunts are all different. We couldn't just make the closed caption for it [Taunt!].

felis-catus commented 2 years ago

Resolved by https://github.com/nmrih/nmrih-localization-files/pull/57, thanks to Plazehorta!