search

nmrs-nigeria / openmrs-module-nigeriaemr

NMRS NDR Extration Module for NigeriaMRS
1 stars 15 forks source link

Fail NDR Export when critical data is not configured #128

Closed wandechris closed 4 years ago

wandechris commented 4 years ago

Files are generated with missing data that should have been configured. Let's run a precheck of the data and fail the process if any of then is missing,

Example of critical data is

partner_reporting_state partner_reporting_lga_code

brightoibe commented 4 years ago

Hello Team, why is UNKNOWNUNKNOWN apearing on the XML file names. I thought we are using DATIMCODE_PEPFARID_TIMESTAMP.xml as the names of the individual files.

wandechris commented 4 years ago

@brightoibe UNKNOWN is appearing because partner_reporting_state and partner_reporting_lga_code is not configured in global property, the filename has changed to

IPReportingState + IPReportingLgaCode + "_" + DATIMID + "_" + formattedDate

@wonderfulguru1 please let me know if I missed anything

brightoibe commented 4 years ago

So, It means if your IP is in 4 states for example, all the NMRS instance in those states will be configured to have different "partner_reporting_state" and "partner_reporting_lga_code". I feel this will not be convinient. Is it posible for "State" and "LGA" to be calculated from DATIMID from NDR end. It will be nice to make configuration and set up as user friendly as posible. To reduce errors.

brightoibe commented 4 years ago

Hello Team,

Can Viral Loads accept "decimals" now?

wonderfulguru1 commented 4 years ago

@brightoibe this was suggested by @caniekwe and he explained why during the last meeting you may want to bring this up again with him

wandechris commented 4 years ago

Hello Team,

Can Viral Loads accept "decimals" now?

is it supposed to, you can raise another issue to address this

wonderfulguru1 commented 4 years ago

Hello Team,

Can Viral Loads accept "decimals" now?

I Guess the form team @enumahin and @teggsdgreat can throw better light on this but if the form can accept it then pulling via the export plugin won't be an issue

caniekwe commented 4 years ago

@wonderfulguru1 I believe we can close this issue now since the different issues raised are being addressed by https://github.com/nmrs-nigeria/openmrs-module-nigeriaemr/issues/130 and https://github.com/nmrs-nigeria/openmrs-module-nigeriaemr/issues/131

wandechris commented 4 years ago

@caniekwe the purpose of this issue is to fail the process if LGAand state is not configured or have an UNKNOWN value

wandechris commented 4 years ago

@wonderfulguru1 the purpose of this issue is to stop the process if UNKNOWN is configured to avoid creating files