Closed tonymet closed 4 years ago
https://github.com/nmrshll/gphotos-uploader-cli/issues/53
please see the build steps above and test
For you: 🏆
Thank you so much for this @tonymet 🙏
Finally got this back to working
I've tested it, It works like a charm... My only concern is if we should vendor all and use go mod
. The current approach mod
+ vendor
is a bit strange to me.
What do you think?
@pacoorozco I just need to work with @nmrshll to go full-mod. Right now in my testing GO111MODULE=on doesn't work for a couple reasons. Overall I'm for it--but this PR is to fix the immediate issue until we do
@nmrshll Looks like some good testing. I'll self-merge later today if that's ok
@nhorvath could i get your help merging?
@nhorvath @pacoorozco Hi guys I have a few pull requests out that I think would be a help. What would be the best way to help get those merged?
@tonymet I'm not really a go developer, but i helped with some early functionality for large photo libraries which is why i'm here. Sorry, but I don't know what this PR does so I will have to deffer to someone else.
NOTE use
GO111MODULE=off
when buildingI've vendored
google.golang.org/api/photoslibrary/xxx
fixes https://github.com/nmrshll/gphotos-uploader-cli/issues/53Building Examples
this package
the main gphotos-uploader-cli