nmrshll / google-photos-api-client-go

Google photos api client in go
35 stars 12 forks source link

add google.golang.org/api/photoslibrary/v1 to vendor #4

Closed tonymet closed 4 years ago

tonymet commented 5 years ago

NOTE use GO111MODULE=off when building

I've vendored google.golang.org/api/photoslibrary/xxx fixes https://github.com/nmrshll/gphotos-uploader-cli/issues/53

Building Examples

this package

GO111MODULE=off go build lib-gphotos/*.go
GO111MODULE=off go build noserver-gphotos/*.go

the main gphotos-uploader-cli

cd $GOROOT/src/github.com/nmrshll/gphotos-uploader-cli
GO111MODULE=off go build cmd/gphotos-uploader-cli/main.go
tonymet commented 5 years ago

https://github.com/nmrshll/gphotos-uploader-cli/issues/53

please see the build steps above and test

jayroh commented 5 years ago

For you: 🏆

Thank you so much for this @tonymet 🙏

Finally got this back to working

pacoorozco commented 5 years ago

I've tested it, It works like a charm... My only concern is if we should vendor all and use go mod. The current approach mod + vendor is a bit strange to me.

What do you think?

tonymet commented 5 years ago

@pacoorozco I just need to work with @nmrshll to go full-mod. Right now in my testing GO111MODULE=on doesn't work for a couple reasons. Overall I'm for it--but this PR is to fix the immediate issue until we do

tonymet commented 5 years ago

@nmrshll Looks like some good testing. I'll self-merge later today if that's ok

tonymet commented 5 years ago

@nhorvath could i get your help merging?

tonymet commented 5 years ago

@nhorvath @pacoorozco Hi guys I have a few pull requests out that I think would be a help. What would be the best way to help get those merged?

nhorvath commented 5 years ago

@tonymet I'm not really a go developer, but i helped with some early functionality for large photo libraries which is why i'm here. Sorry, but I don't know what this PR does so I will have to deffer to someone else.

pacoorozco commented 5 years ago

Fixed on https://github.com/gphotosuploader/google-photos-api-client-go