search

nmslib / hnswlib

Header-only C++/python library for fast approximate nearest neighbors
https://github.com/nmslib/hnswlib
Apache License 2.0
4.11k stars 607 forks source link

CMakeLists needs a fix for some hardcoded flags #547

Open barracuda156 opened 3 months ago

barracuda156 commented 3 months ago

Some of the hardcoded flags here are wrong: https://github.com/nmslib/hnswlib/blob/master/CMakeLists.txt

  1. -march= is not supported on PowerPC, -mtune= is.

  2. -lrt is a BSD library, it should not be used on macOS, AFAIK.

yurymalkov commented 3 months ago

Hi @barracuda156, Can you please fix it wit a PR (and maybe test)?

barracuda156 commented 3 months ago

@yurymalkov Will it run CI here? I will check on macOS locally, but I cannot check it on Linux or BSD. https://github.com/nmslib/hnswlib/pull/550