nmstate / .github

0 stars 2 forks source link

Proposal to add nmstate-ts library #1

Closed upalatucci closed 1 year ago

phoracek commented 1 year ago

@cathay4t :wave:

cathay4t commented 1 year ago

@upalatucci Could you help me for these questions?

upalatucci commented 1 year ago

Nice. Thanks for the yaml documentation.

About the version: the code under model folder is generated using the crds. In the NodeNetworkState Crd for example, multiple versions are provided. v1alpha1 and v1beta1 so the tool generated V1Alpha1NodeNetworkState and V1beta1NodeNetworkState.

Example in readme: yes for sure

cathay4t commented 1 year ago

Any special reason we call it v1alpha1 and v1beta1

upalatucci commented 1 year ago

I don't know. There are just in the cards. Maybe @phoracek knows more about that. But it follows the k8s standard versioning I think btw there are issues with metadata and conditions. In the crds they are marked as objects but i think we can use the metadata and condition definitions here. In my typescript code I've just manually adjusted that. To have a more precise type definition

qinqon commented 1 year ago

On Wed, Dec 21, 2022 at 11:47 AM Ugo Palatucci @.***> wrote:

I don't know. There are just in the cards. Maybe @phoracek https://github.com/phoracek knows more about that. But it follows the k8s standard versioning I think btw there are issues with metadata and conditions. In the crds they are marked as objects but i think we can use the metadata and condition definitions here. In my typescript code I've just manually adjusted that. To have a more precise type definition

We should comply with k8s API versioning format.

— Reply to this email directly, view it on GitHub https://github.com/nmstate/.github/pull/1#issuecomment-1361156437, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYRGSXEOMTTYTQSGYR4DR3WOLN4NANCNFSM6AAAAAAS3W6EJA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Quique Llorente

CNV networking Senior Software Engineer

Red Hat EMEA https://www.redhat.com/

@. @.> @RedHat https://twitter.com/redhat Red Hat https://www.linkedin.com/company/red-hat Red Hat https://www.facebook.com/RedHatInc https://www.redhat.com/