nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
184 stars 90 forks source link

e2e,upgrade: fall back to current examples if needed #1120

Closed rhrazdil closed 2 years ago

rhrazdil commented 2 years ago

Signed-off-by: Radim Hrazdil rhrazdil@redhat.com

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What this PR does / why we need it: When testing upgrade, example yamls from previous tag are downloaded. This causes an issue when adding a new example yaml, because it doesn't yet exist in previous tag.

This change falls back to current doc/examples path if an example yaml is not found in previous tag. This allows to smoothly add new example yamls.

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 2 years ago

@rhrazdil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-upgrade-k8s 9b46ab16157c0eccb92157d80438b020a3b5cb5d link false /test pull-kubernetes-nmstate-e2e-upgrade-k8s
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment