search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
177 stars 87 forks source link

e2e,doc: Add LLDP example #1122

Closed rhrazdil closed 1 year ago

rhrazdil commented 1 year ago

Signed-off-by: Radim Hrazdil rhrazdil@redhat.com

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What this PR does / why we need it: This commit adds example yaml of a policy enabling LLDP on all ethernet interfaces that are at state: up.

The lldp scenario has to be skipped at upgrade lane because older knmstate doesn't feature nmpolicy version enabling this nmpolicy expression.

Special notes for your reviewer:

Release note:

Add LLDP example policy
kubevirt-bot commented 1 year ago

@rhrazdil: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future 7e26b33a285ecd97afc3c73c4bf1982cd6551bbe link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
qinqon commented 1 year ago

/retest pull-kubernetes-nmstate-e2e-handler-k8s-future

kubevirt-bot commented 1 year ago

@qinqon: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1122#issuecomment-1256000639): >/retest pull-kubernetes-nmstate-e2e-handler-k8s-future Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 1 year ago

/retest pull-kubernetes-nmstate-e2e-handler-k8s-future

kubevirt-bot commented 1 year ago

@qinqon: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1122#issuecomment-1256004660): >/retest pull-kubernetes-nmstate-e2e-handler-k8s-future Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/lgtm /approve /hold Future lane is suppose to be fine now

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qinqon commented 1 year ago

/hold cancel