Open constcrist opened 1 year ago
/assign
@phoracek is this one working as expected or needs some work?
@dougsland I don't know how common is the insteadOf
config, but I'd agree that the script should be resilient enough to bring up a cluster even if there is a special config in place.
What happened:
make cluster-up
would stop without properly configuring the local cluster. Somewhere midway the installation scripts:_kubevirtci
repository, reclone it;_kubevirtci/_ci-configs/k8s-1.22/.kubectl
which is no longer there (maybe because it is not re-compiled?)Snippet from the logs dumped by
make cluster-up
:I have traced this back to:
git configuration on the test machine is rewriting the git URL in
.gitconfig
:the following test in the
cluster/kubevirtci.sh
script fails and triggers re-cloning:As soon as I modify the
KUBEVIRTCI_REPO
to point togit@github.com:kubevirt/kubevirtci.git
(which matches what is used on the test machine) installation works.What you expected to happen: Imo, ideally
make cluster-up
should work regardless of the git URL re-writing rules. Maybe, at least the documentation here: https://nmstate.io/kubernetes-nmstate/deployment/local-cluster.html should tell the user to set-up accordingly theKUBEVIRTCI_REPO
in thecluster/kubevirtci.sh
script.How to reproduce it (as minimally and precisely as possible):
make cluster-up
Anything else we need to know?:
Environment:
NodeNetworkState
on affected nodes (usekubectl get nodenetworkstate <node_name> -o yaml
):NodeNetworkConfigurationPolicy
:kubectl get pods --all-namespaces -l app=kubernetes-nmstate -o jsonpath='{.items[0].spec.containers[0].image}'
):nmcli --version
)kubectl version
):