nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
184 stars 90 forks source link

Bump kubevirtci #1130

Closed oshoval closed 1 year ago

oshoval commented 1 year ago

Is this a BUG FIX or a FEATURE ?: /kind enhancement

What this PR does / why we need it: Bump kubevirtci to consume a newer version

Special notes for your reviewer:

Release note:

None
oshoval commented 1 year ago

I don't see any reason not to update the tag. Only the justification in the PR description is off - there is no reason to align with CNAO, as CNAO is unrelated to this project at this point. CNAO doesn't deploy knmstate anymore.

Right thanks updated

kubevirt-bot commented 1 year ago

@oshoval: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future ee6cbe8a5e4643942ab30df6ed3a3ae063d63640 link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
oshoval commented 1 year ago

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/nmstate_kubernetes-nmstate/1130/pull-kubernetes-nmstate-e2e-handler-k8s-future/1592077109033963520

not due to this PR right ? (i saw this lane really flaky in the past but not sure what is the current status and which tests are flaky)

rhrazdil commented 1 year ago

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/nmstate_kubernetes-nmstate/1130/pull-kubernetes-nmstate-e2e-handler-k8s-future/1592077109033963520 not due to this PR right ? (i saw this lane really flaky in the past but not sure what is the current status and which tests are flaky)

Yes, this is not related /approve /lgtm

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [rhrazdil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
oshoval commented 1 year ago

Thanks Radim