Closed andreaskaris closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rhrazdil for approval by writing /assign @rhrazdil
in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Hi @andreaskaris. Thanks for your PR.
I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
I was 2 weeks late, fede++ already submitted a pr: https://github.com/nmstate/kubernetes-nmstate/pull/1153
When nmstate configures additional routes inside VRFs (or any other non-default route table), ignore these routes for the GW ping probe.
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it: See https://issues.redhat.com/browse/OCPBUGS-10245
Special notes for your reviewer:
Release note: