Closed orenc1 closed 1 year ago
Hi @orenc1. Thanks for your PR.
I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
@orenc1: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: qinqon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest
/ok-to-test /retest
There is something bad at centos 9 stream
The error doesn't seem related to the patch:
GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial
Public key for scl-utils-2.0.3-4.el9.x86_64.rpm is not installed. Failing package is: scl-utils-1:2.0.3-4.el9.x86_64
GPG Keys are configured as: file:///etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial
The downloaded packages were saved in cache until the next successful transaction.
You can remove cached packages by executing 'dnf clean packages'.
Error: GPG check FAILED
Error: building at STEP "RUN dnf install -y golang-$(sed -En 's/^go +(.*+)$/\1/p' go.mod).*": while running runtime: exit status 1
/retest-required
There's a problem with the centos 9 repos. A workaround is proposed here https://github.com/nmstate/kubernetes-nmstate/pull/1168 so that will need to merge before this will pass.
/retest
The centos 9 stream RPM issue has being fixed upstream, but looks like we have e2e test issue at main
/retest
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it: If for whatever reason the UI manifests does not exist in the operator's filesystem, we don't want the operator to deploy UI-related resources, resulting in an error log. Special notes for your reviewer:
Release note: