nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

Uninstall Leaves CRDs Behind #1166

Closed anandgiddani closed 1 year ago

anandgiddani commented 1 year ago

What happened: While I am trying to uninstall/delete the nmstate from K8s cluster, CRDs are not removing.

What you expected to happen: While installing NMState CR it is creating CRDs and while uninstalling the CR it should delete those CRDs.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment: K8s Cluster

qinqon commented 1 year ago

CRDs are not removed by design

anandgiddani commented 1 year ago

so we need to remove those manually after deleting/uninstalling the nmstate? per my understanding, CRDs are created while creating NMState CR so I am expecting to delete those CRDs while CR is deleting.

qinqon commented 1 year ago

@cybertron do you remember why was like that ? I think it was realted to upgrade so users don't get their NNCPs removed, although I don't know why create/delete/create of NMstate has to be done at upgrades.

cybertron commented 1 year ago

I do not remember. All of that is managed by OLM so if that's the behavior it would be on their side.

Although maybe it had something to do with the migration from CNV to standalone? I thought in that case they were installed side-by-side, but I guess if you uninstalled and then reinstalled it might be a problem? Or maybe when you uninstalled the old one it would remove the CRDs for both?

qinqon commented 1 year ago

Closing since this is by design