nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

build: Use ubi9 go toolset images and remove docker #1167

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

What this PR does / why we need it: To reduce build time we can use golang ready image so golang do not need to be installed, also is safe now to depend on podman 4 so we remove docker dependecy and build infra.

Special notes for your reviewer: It also contains a woraround for current centos 9 stream bug:

rpm --import /etc/pki/rpm-gpg/RPM-GPG-KEY-centosofficial

Release note:

NONE
qinqon commented 1 year ago

/cc @cybertron @phoracek

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from qinqon by writing /assign @qinqon in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest

nmstate-cert-manager-5449b9598d-g89qk   0/1     ImagePullBackOff    0          2m5s    10.244.196.134   node01   <none>           <none>
nmstate-handler-7k8vc                   0/1     ImagePullBackOff    0          2m1s    192.168.66.105   node05   <none>           <none>
nmstate-handler-cmhjm                   0/1     ImagePullBackOff    0          2m2s    192.168.66.103   node03   <none>           <none>
nmstate-handler-jbdlv                   0/1     ImagePullBackOff    0          2m2s    192.168.66.104   node04   <none>           <none>
nmstate-handler-z6dpn                   0/1     ImagePullBackOff    0          2m2s    192.168.66.102   node02   <none>           <none>
qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest

kubevirt-bot commented 1 year ago

@qinqon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-upgrade-k8s 128561df1ed1730e48b744b67240e7311baeb461 link false /test pull-kubernetes-nmstate-e2e-upgrade-k8s
pull-kubernetes-nmstate-e2e-handler-k8s 128561df1ed1730e48b744b67240e7311baeb461 link true /test pull-kubernetes-nmstate-e2e-handler-k8s
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).