search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

handler: Remove link unavailable w/a #1170

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

What this PR does / why we need it: There is a quite old NetworkManager 1.20 issue where link where not up [1], and k-nmstate do have a workaround for it. This change remove the workaround since it's quite old and possible not needed.

Special notes for your reviewer:

Release note:

Remove link unavailable workaround
qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest 

===== 34bfee44934ac9f2b042a91f51e847088772839db58cd829935db6af7cb84c58 ====
Error response from daemon: cannot listen on the TCP port: listen tcp4 :43655: bind: address already in use
make: *** [Makefile:188: cluster-up] Error 1
qinqon commented 1 year ago

/retest

cybertron commented 1 year ago

/lgtm

Assuming this passes ci.

qinqon commented 1 year ago

/approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment