search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

handler: Remove nmcli vlan-filtering activation #1171

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

What this PR does / why we need it: For upgrade purposes the vlan filtering was being configured with nmcli before apply the modified state so the old ip link version of k-nmstate will not fail on nmstate verification. This change remove the nmcli command to configure vlan filterind and also the nmcli versioning at NNS since we no longer need it, it also remove NetworkManager from the container.

Release note:

Don't configure vlan filtering with nmcli and remove nmcli version from NNS
qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest

cybertron commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [cybertron] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qinqon commented 1 year ago

/retest