search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

cluster: Skip NM auto-profile for sec interfaces #1175

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

What this PR does / why we need it: Sometimes the eth2 interface comes up without explicitly saying so. This change copy the mechanism at openshift operator to prevent that [1].

[1] https://github.com/openshift/kubernetes-nmstate/blame/master/test/e2e/machineconfigs.yaml#L21

Release note:

NONE
qinqon commented 1 year ago

/test pull-kubernetes-nmstate-e2e-handler-k8s

Running it again to check if it's not a false possitive.

cybertron commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [cybertron] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment