search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

Enable ipv4 and ipv6 on primary nic when resetting #1180

Closed cybertron closed 1 year ago

cybertron commented 1 year ago

By default NMState disables ipv4 and ipv6 if they are not explicitly set to enabled. This can cause the reset policy to break network connectivity on nodes since the primary interface may lose all of its addresses. To avoid that, set both ipv4 and ipv6 to enabled with DHCP so we will always configure them with an address.

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/retest