search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

handler: Propertly filter unmanaged veth #1181

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

Is this a BUG FIX or a FEATURE ?: /kind bug

What this PR does / why we need it: The number of veth interfaces not managed by NetworkManager at a k8s cluster is massive since they are all the network interfaces of containers running at the node and it pollute the NodeNetworkState without much use, to fix that there is a code that ignore those. At some envs the "veth" parth is not present since the peer is at different namespace so the detection logic was failing. This change goes back to use "type == veth" now that the veth type is no longer "ethernet".

Release note:

Fix fitering out unmanaged veths
cybertron commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [cybertron] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment