openshift, operator: Copy ui-plugin to bindir

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.

GNU General Public License v2.0

176 stars 87 forks source link

openshift, operator: Copy ui-plugin to bindir #1185

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

Is this a BUG FIX or a FEATURE ?:

/kind bug

Closes https://issues.redhat.com/browse/OCPBUGS-13096

What this PR does / why we need it: The ui-plugin manifest were copy at the k8s operator Dockerfile but not at the openshift one.

Release note:

Add ui-plugin manifests to the openshift operator

qinqon commented 1 year ago

@cybertron @dougsland we need to rebase this at openshift

qinqon commented 1 year ago

/hold

Why this is not failing ? the openshift/ui-plugin directory do not exist

  _, errUIPluginPathExists := os.Stat(filepath.Join("openshift", "ui-plugin"))

Looks like openshift is not taking:

https://github.com/nmstate/kubernetes-nmstate/pull/1165

qinqon commented 1 year ago

/retest

cybertron commented 1 year ago

/lgtm

We already did the dockerfile change downstream, but it might as well be here too: https://github.com/openshift/kubernetes-nmstate/commit/5d6a8cde125b8f5cc220a2629168c738bb562736

qinqon commented 1 year ago

/hold cancel

qinqon commented 1 year ago

/approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

shivangnayar-dev commented 1 year ago

can i be assigned this issue