search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

api: Updated to print State Age column for NNCE #1186

Closed SudhanAruna closed 1 year ago

SudhanAruna commented 1 year ago

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What this PR does / why we need it: Updated to display Status Age column when listing NNCE using kubectl fixes #1133 Special notes for your reviewer:

Release note:

api: Updated to print State Age column for NNCE
kubevirt-bot commented 1 year ago

Hi @SudhanAruna. Thanks for your PR.

I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 1 year ago

/test all

qinqon commented 1 year ago

/lgtm /approve

Thanks!

qinqon commented 1 year ago

You have to run make generate to update the CRDs not doing it manually.

qinqon commented 1 year ago

/ok-to-test

SudhanAruna commented 1 year ago

Can you call make generate and push changes ?

Sure

qinqon commented 1 year ago

/retest

qinqon commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment