nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

handler: Install nmstate from proper arch #1188

Closed qinqon closed 1 year ago

qinqon commented 1 year ago

Is this a BUG FIX or a FEATURE ?:

/kind bug Closes https://github.com/nmstate/kubernetes-nmstate/issues/1178

What this PR does / why we need it: The handler was installing a amd64 image, this change remove the optimization of forcing the platform at build stage to do crosscompiling so last stage is using the proper architecture, this way the rpm is installed from the proper arch.

Release note:

Propertly build images for non  amd64
cybertron commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [cybertron] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment