Closed andreaskaris closed 1 year ago
Hi @andreaskaris. Thanks for your PR.
I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/test
@qinqon: The /test
command needs one or more targets.
The following commands are available to trigger required jobs:
/test pull-kubernetes-nmstate-docs
/test pull-kubernetes-nmstate-e2e-handler-k8s
/test pull-kubernetes-nmstate-e2e-operator-k8s
/test pull-kubernetes-nmstate-unit-test
The following commands are available to trigger optional jobs:
/test pull-kubernetes-nmstate-e2e-handler-k8s-future
/test pull-kubernetes-nmstate-e2e-upgrade-k8s
Use /test all
to run all jobs.
/test all
/ok-to-test
/retest
nit doc: Can you add the example to https://github.com/nmstate/kubernetes-nmstate/blob/main/docs/examples.md ? the examples index is not dynamic
done :-)
/retest
The example is present at generated docs https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/nmstate_kubernetes-nmstate/1189/pull-kubernetes-nmstate-docs/1663472420981313536/artifacts/gh-pages/examples.html#vrf
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: qinqon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Is this a BUG FIX or a FEATURE ?: /kind enhancement
What this PR does / why we need it: Create E2E tests and add an example for VRFs to make sure that the feature works.
Special notes for your reviewer: Reported-at: https://github.com/nmstate/kubernetes-nmstate/issues/847 Fixes: https://github.com/nmstate/kubernetes-nmstate/issues/847
Release note: