nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

Add E2E tests and example for VRFs #1189

Closed andreaskaris closed 1 year ago

andreaskaris commented 1 year ago

Is this a BUG FIX or a FEATURE ?: /kind enhancement

What this PR does / why we need it: Create E2E tests and add an example for VRFs to make sure that the feature works.

Special notes for your reviewer: Reported-at: https://github.com/nmstate/kubernetes-nmstate/issues/847 Fixes: https://github.com/nmstate/kubernetes-nmstate/issues/847

Release note:

NONE
kubevirt-bot commented 1 year ago

Hi @andreaskaris. Thanks for your PR.

I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 1 year ago

/test

kubevirt-bot commented 1 year ago

@qinqon: The /test command needs one or more targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1189#issuecomment-1567132386): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 1 year ago

/test all

qinqon commented 1 year ago

/ok-to-test

qinqon commented 1 year ago

/retest

andreaskaris commented 1 year ago

nit doc: Can you add the example to https://github.com/nmstate/kubernetes-nmstate/blob/main/docs/examples.md ? the examples index is not dynamic

done :-)

andreaskaris commented 1 year ago

/retest

qinqon commented 1 year ago

The example is present at generated docs https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/nmstate_kubernetes-nmstate/1189/pull-kubernetes-nmstate-docs/1663472420981313536/artifacts/gh-pages/examples.html#vrf

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment