nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

Use ginkgo-2.1.5 #1191

Closed cybertron closed 1 year ago

cybertron commented 1 year ago

Looking to pull in the summary fix from https://github.com/onsi/ginkgo/commit/5cf23e264b07a4b6928b02798e594205db9eac89 so we always get summaries, even if there's only a single failure.

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE
cybertron commented 1 year ago

/cc @dougsland

This may help us track down repeated failures in ci jobs. This way you can just check the summary to see if the same tests are failing each time.

kubevirt-bot commented 1 year ago

@cybertron: GitHub didn't allow me to request PR reviews from the following users: dougsland.

Note that only nmstate members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1191#issuecomment-1581613193): >/cc @dougsland > >This may help us track down repeated failures in ci jobs. This way you can just check the summary to see if the same tests are failing each time. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 1 year ago

/lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment