nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

deps: Upgrade ginkgo to 2.11.0 #1199

Closed mkowalski closed 1 year ago

mkowalski commented 1 year ago

Release note:

NONE
kubevirt-bot commented 1 year ago

Hi @mkowalski. Thanks for your PR.

I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mkowalski commented 1 year ago

/ok-to-test

kubevirt-bot commented 1 year ago

@mkowalski: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1199#issuecomment-1645131008): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 1 year ago

/lgtm /approve

qinqon commented 1 year ago

/ok-to-test /lgtm /approve

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkowalski commented 1 year ago

/test pull-kubernetes-nmstate-unit-test

 Waiting for podman socket to be ready, sleeping for 20 seconds.
Reached maximum attempts, not waiting any longer...
Podman daemon failed to start successfully 
mkowalski commented 1 year ago

/test pull-kubernetes-nmstate-unit-test

qinqon commented 1 year ago

/lgtm