nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
176 stars 87 forks source link

[OCPBUGS-16644] Fix nmstate-console-plugin for Single-Stack IPv6 clusters #1200

Closed orenc1 closed 1 year ago

orenc1 commented 1 year ago

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What this PR does / why we need it: When a single-stack IPv6 cluster is being used, the nginx server isn't listening on IPv6 requests, just IPv4. Changing the nginx configuration listen directive to [::]:9443 ipv6only=off ssl will accept connections both for IPv6 and IPv4. Also, parametrize the service port. Special notes for your reviewer:

Release note:

fix nmstate-console-plugin in single-stack ipv6 clusters.
kubevirt-bot commented 1 year ago

Hi @orenc1. Thanks for your PR.

I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
orenc1 commented 1 year ago

hi @qinqon , could you please comment here: /ok-to-test ? thanks

kubevirt-bot commented 1 year ago

@orenc1: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1200#issuecomment-1651215255): >hi @qinqon , >could you please comment here: >/ok-to-test >? >thanks Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 1 year ago

/ok-to-test

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment