search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
172 stars 86 forks source link

deps: upgrade golang.org/x/net/html #1201

Closed mkowalski closed 10 months ago

mkowalski commented 11 months ago

This PR ugrades golang.org/x/net/html (and related deps) in order to remediate GO-2023-1988.

NONE
kubevirt-bot commented 11 months ago

Hi @mkowalski. Thanks for your PR.

I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mkowalski commented 11 months ago

/ok-to-test

kubevirt-bot commented 11 months ago

@mkowalski: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1201#issuecomment-1689995800): >/ok-to-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 11 months ago

/lgtm /approve

kubevirt-bot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qinqon commented 11 months ago

/ok-to-test

cybertron commented 11 months ago

/retest-required

qinqon commented 10 months ago

/retest-required

kubevirt-bot commented 10 months ago

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future bfae3129ba9ebb65c9da05e8bc96cafff956491d link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
pull-kubernetes-nmstate-e2e-handler-k8s bfae3129ba9ebb65c9da05e8bc96cafff956491d link true /test pull-kubernetes-nmstate-e2e-handler-k8s
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
qinqon commented 10 months ago

we are investigating the CI failure

qinqon commented 10 months ago

Looks like nmstate rollback is failing 

rollback: failed to execute nmstatectl rollback: 'exit status 1' '' '[2023-09-04T09:31:24Z WARN  nmstate::nm::nm_dbus::error] Unknown DBUS error MethodError(\"org.freedesktop.DBus.Error.NoReply\", Some(\"Remote peer disconnected\"), Msg { type: Error, sender: \"org.freedesktop.DBus\", reply-serial: 3, body: Signature: [
    \ts (115),                                                                  
    ] })                                                                        
NmstateError: Bug: DbusConnectionError: org.freedesktop.DBus.Error.NoReply: Remote peer disconnected
'","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
\t/opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:121
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
\t/opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:320
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
\t/opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:273
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
\t/opt/app-root/src/vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:234"}

Update: looks like NM is crashing at a known issue

Sep 04 09:31:24 node02 NetworkManager[4697]: <info>  [1693819884.3900] device (eth0)[Open vSwitch Port]: state change: activated -> deactivating (reason 'connection-removed', sys-iface-state: 'managed')
Sep 04 09:31:24 node02 NetworkManager[4697]: <info>  [1693819884.3903] device (eth0)[Open vSwitch Port]: released from master device br1
Sep 04 09:31:24 node02 NetworkManager[4697]: <info>  [1693819884.3909] device (ovs666)[Open vSwitch Port]: state change: activated -> deactivating (reason 'connection-removed', sys-iface-state: 'managed')
Sep 04 09:31:24 node02 NetworkManager[4697]: <info>  [1693819884.3912] device (ovs666)[Open vSwitch Port]: released from master device br1
Sep 04 09:31:24 node02 NetworkManager[4697]: <info>  [1693819884.3922] device (br1)[Open vSwitch Bridge]: state change: activated -> deactivating (reason 'connection-removed', sys-iface-state: 'managed')
Sep 04 09:31:24 node02 NetworkManager[4697]: <info>  [1693819884.3933] device (ovs666)[Open vSwitch Interface]: state change: activated -> deactivating (reason 'connection-removed', sys-iface-state: 'managed')
Sep 04 09:31:24 node02 NetworkManager[4697]: <info>  [1693819884.3935] device (ovs666)[Open vSwitch Port]: detaching ovs interface ovs666
Sep 04 09:31:24 node02 NetworkManager[4697]: <info>  [1693819884.3938] device (ovs666)[Open vSwitch Interface]: released from master device ovs666
Sep 04 09:31:24 node02 systemd-coredump[9539]: Process 4697 (NetworkManager) of user 0 dumped core. 
Sep 04 09:31:24 node02 systemd[1]: NetworkManager.service: Main process exited, code=dumped, status=11/SEGV 
Sep 04 09:31:24 node02 systemd[1]: NetworkManager.service: Failed with result 'core-dump'.
Sep 04 09:31:24 node02 systemd[1]: NetworkManager.service: Consumed 2.838s CPU time. 
Sep 04 09:31:24 node02 systemd[1]: NetworkManager.service: Scheduled restart job, restart counter is at 1. 
Sep 04 09:31:24 node02 systemd[1]: Stopped Network Manager.                     
Sep 04 09:31:24 node02 systemd[1]: NetworkManager.service: Consumed 2.838s CPU time. 
Sep 04 09:31:24 node02 systemd[1]: Starting Network Manager...                  
Sep 04 09:31:24 node02 NetworkManager[9546]: <info>  [1693819884.7385] NetworkManager (version 1.44.0-2.el9) is starting... (after a restart, boot:5b4b5868-d074-4d46-97f6-44e8de3c75a8)
qinqon commented 10 months ago

Going to force merge it since it's not related