search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
172 stars 86 forks source link

deps: Bump go 1.19 and some deps #1206

Closed qinqon closed 9 months ago

qinqon commented 10 months ago

What this PR does / why we need it: Bump to:

Special notes for your reviewer: There are changes at the code to fix linting, since there is new stuff from go1.19 There is no proper image for go 1.20 at quay.io so we stick with 1.19 for now The k8s version is the oldest one that supports controller-runtime 0.14.6 The controller-runtime is the minimal we need for kube-addmission-webhook.

Release note:

Bump: go 1.19, controller-runtime v0.14.6 and k8s 1.26.3
mkowalski commented 10 months ago

/approve

Wow what a monster, thanks! Let me just see green CI and let's ship it

kubevirt-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [mkowalski] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
qinqon commented 10 months ago

/retest

qinqon commented 10 months ago

There is a proper failure after fixing the lints, looks like PollUntilContextTimeout return the error but PollImmediate was not returning the timeout error

At least e2e tests is fine.

mkowalski commented 9 months ago

/lgtm