search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
172 stars 86 forks source link

Upgrade controller-runtime to v0.15 #1212

Closed mkowalski closed 5 months ago

mkowalski commented 9 months ago

Is this a BUG FIX or a FEATURE ?:

/kind bug

What this PR does / why we need it:

We are upgrading controller-runtime to v0.15.2; because of breaking changes between v0.14 and v0.15, additional changes are needed in the way we use cache

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 9 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

kubevirt-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from mkowalski. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkowalski commented 9 months ago

/test unit-test

kubevirt-bot commented 9 months ago

@mkowalski: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run all jobs.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1212#issuecomment-1771042556): >/test unit-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mkowalski commented 9 months ago

/test pull-kubernetes-nmstate-unit-test

mkowalski commented 9 months ago

/test pull-kubernetes-nmstate-unit-test

mkowalski commented 9 months ago

/test pull-kubernetes-nmstate-unit-test

mkowalski commented 9 months ago

/test pull-kubernetes-nmstate-unit-test

mkowalski commented 9 months ago

/test pull-kubernetes-nmstate-unit-test

mkowalski commented 9 months ago

/test pull-kubernetes-nmstate-unit-test

mkowalski commented 9 months ago

/test pull-kubernetes-nmstate-unit-test

mkowalski commented 9 months ago

/test pull-kubernetes-nmstate-unit-test

mkowalski commented 9 months ago

/test pull-kubernetes-nmstate-unit-test

kubevirt-bot commented 9 months ago

@mkowalski: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future b6456a1dcb3ebaccfde978cf542713ea2199cb24 link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
pull-kubernetes-nmstate-e2e-upgrade-k8s b6456a1dcb3ebaccfde978cf542713ea2199cb24 link false /test pull-kubernetes-nmstate-e2e-upgrade-k8s
pull-kubernetes-nmstate-e2e-handler-k8s b6456a1dcb3ebaccfde978cf542713ea2199cb24 link true /test pull-kubernetes-nmstate-e2e-handler-k8s
pull-kubernetes-nmstate-e2e-operator-k8s b6456a1dcb3ebaccfde978cf542713ea2199cb24 link true /test pull-kubernetes-nmstate-e2e-operator-k8s
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mkowalski commented 9 months ago

/hold

For some reason daemon set is missing. I feel like it needs manual test

kubevirt-bot commented 6 months ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.