go: Bump to 1.20 - Githubissues

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.

GNU General Public License v2.0

181 stars 89 forks source link

go: Bump to 1.20 #1224

Closed qinqon closed 8 months ago

qinqon commented 8 months ago

What this PR does / why we need it:

Bump go to 1.20

go1.20

qinqon commented 8 months ago

/cc @mkowalski

mkowalski commented 8 months ago

/retest /lgtm

This makes sense, I will happily start using more recent go

mkowalski commented 8 months ago

/retest

mkowalski commented 8 months ago

/test pull-kubernetes-nmstate-e2e-handler-k8s-future

kubevirt-bot commented 8 months ago

@qinqon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future	290a216940b449b218194c847babd12909b3ed22	link	false	`/test pull-kubernetes-nmstate-e2e-handler-k8s-future`

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

cybertron commented 8 months ago

/retest-required /approved

cybertron commented 8 months ago

/approve

Typing is hard. :-)

kubevirt-bot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [cybertron] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

qinqon commented 8 months ago

Something is broken at nmstate, future lane is failing at doing an ovs-bridge with with an "state: ignore" (unamanaged) interface

qinqon commented 8 months ago

/test pull-kubenetes-nmstate-unit-test

kubevirt-bot commented 8 months ago

@qinqon: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

/test pull-kubernetes-nmstate-docs
/test pull-kubernetes-nmstate-e2e-handler-k8s
/test pull-kubernetes-nmstate-e2e-operator-k8s
/test pull-kubernetes-nmstate-unit-test

The following commands are available to trigger optional jobs:

/test pull-kubernetes-nmstate-e2e-handler-k8s-future
/test pull-kubernetes-nmstate-e2e-upgrade-k8s

Use /test all to run all jobs.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1224#issuecomment-1914661407): >/test pull-kubenetes-nmstate-unit-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

qinqon commented 8 months ago

/test pull-kubernetes-nmstate-unit-test

kubevirt-bot commented 8 months ago

New changes are detected. LGTM label has been removed.