metrics: change port used by metrics server

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.

GNU General Public License v2.0

172 stars 86 forks source link

metrics: change port used by metrics server #1233

Closed mkowalski closed 2 months ago

mkowalski commented 3 months ago

Currently metrics server uses port :8080 what has a high chance of conflicting with other services. In order to decrease a chance of the conflict we are moving to :8089.

NONE

mkowalski commented 3 months ago

/retest

Some stupid error


+ curl -k -L https://github.com/nmstate/kubernetes-nmstate/releases/download/v0.82.0/examples.tar.gz -o examples.tar.gz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100     9  100     9    0     0     26      0 --:--:-- --:--:-- --:--:--    26
100     9  100     9    0     0     26      0 --:--:-- --:--:-- --:--:--    26
+ tar -xvf examples.tar.gz
tar: This does not look like a tar archive

qinqon commented 3 months ago

/lgtm /approve

qinqon commented 3 months ago

/retest

mkowalski commented 3 months ago

/test pull-kubernetes-nmstate-e2e-handler-k8s

mkowalski commented 3 months ago

/test pull-kubernetes-nmstate-e2e-handler-k8s

It's failure in the metrics tests but I hope it's a flake

Handler E2E Test Suite: [It] Metrics when desiredState is configured with a state that increase gauge should report a metrics with proper gauge increased expand_more   33s
Handler E2E Test Suite: [It] Metrics when desiredState is configured with a state that increase gauge and update with an state that decrease the gaugue should report a metrics with proper gauge decrease expand_more

mkowalski commented 3 months ago

/test pull-kubernetes-nmstate-e2e-operator-k8s Non-metric related test failed

/test pull-kubernetes-nmstate-e2e-handler-k8s Infra failure

kubevirt-bot commented 3 months ago

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-nmstate-e2e-upgrade-k8s	ea7aa4dba6a03b10b4e4262644d0d19cab904314	link	false	`/test pull-kubernetes-nmstate-e2e-upgrade-k8s`

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

mkowalski commented 3 months ago

/retest-required

qinqon commented 2 months ago

/lgtm /approve

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment