search

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.
GNU General Public License v2.0
172 stars 86 forks source link

api: add ovn bridge mappings to node network state #1237

Closed maiqueb closed 2 months ago

maiqueb commented 2 months ago

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug /kind enhancement

What this PR does / why we need it: This PR exposes the node's ovn bridge mappings (already provided on nmstatectl show) via the NNS object.

Special notes for your reviewer:

Release note:

Display OVN bridge mappings on the NodeNetworkState object
kubevirt-bot commented 2 months ago

Hi @maiqueb. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
maiqueb commented 2 months ago

/cc @qinqon

qinqon commented 2 months ago

/lgtm /approve

qinqon commented 2 months ago

/lgtm /ok-to-test

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maiqueb commented 2 months ago

/test pull-kubernetes-nmstate-e2e-operator-k8s

kubevirt-bot commented 2 months ago

@maiqueb: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1237#issuecomment-2095574644): >/test pull-kubernetes-nmstate-e2e-operator-k8s Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
qinqon commented 2 months ago

/ok-to-test

maiqueb commented 2 months ago

/test pull-kubernetes-nmstate-e2e-operator-k8s

kubevirt-bot commented 2 months ago

@maiqueb: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/nmstate/kubernetes-nmstate/pull/1237#issuecomment-2095596515): >/test pull-kubernetes-nmstate-e2e-operator-k8s Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
maiqueb commented 2 months ago

/test pull-kubernetes-nmstate-e2e-operator-k8s

kubevirt-bot commented 2 months ago

@maiqueb: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future caf1f23da1dd19142415e24b580a2f700fcbb02f link false /test pull-kubernetes-nmstate-e2e-handler-k8s-future
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
maiqueb commented 2 months ago

hm, I'm checking this locally and it passes.

Could it be we need to somehow integrate OVS in CI for this to work ?

maiqueb commented 2 months ago

/test pull-kubernetes-nmstate-e2e-handler-k8s

maiqueb commented 2 months ago

@qinqon ok, so this got merged.

When / how will it become available downstream ? What's the flow here ? ... Will it be automatically cherry-picked downstream by some automation, or do I need to do something further ?

Thanks for your help and time.

mkowalski commented 2 months ago

It will land in downstream automatically after a few days. Unless you have a critical case and need it in downstream immediately, there is nothing to do at all, just sit and watch