e2e: parametrize monitoring namespace

nmstate / kubernetes-nmstate

Declarative node network configuration driven through Kubernetes API.

GNU General Public License v2.0

172 stars 86 forks source link

e2e: parametrize monitoring namespace #1239

Closed mkowalski closed 2 months ago

mkowalski commented 2 months ago

This PR adds ability to manually configure monitoring namespace by using MONITORING_NAMESPACE env variable passed to Makefile, e.g. when executing

make test-e2e-handler

With this change we can run e2e tests in OpenShift clusters which use a different name than our hardcoded monitoring.

Release note:

NONE

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nmstate/kubernetes-nmstate/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

qinqon commented 2 months ago

/retest